Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReduceLROnPlateau object has no attribute 'get_last_lr' #23944

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Fix ReduceLROnPlateau object has no attribute 'get_last_lr' #23944

merged 2 commits into from
Jun 1, 2023

Conversation

wasupandceacar
Copy link
Contributor

What does this PR do?

Fix bug when setting lr_scheduler to ReduceLROnPlateau. When selecting this scheduler, use the optimizer to get the lr.

Refer to this discussion.

Fixes #23934

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@sgugger

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Can you run a quick make style on your branch?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 1, 2023

The documentation is not available anymore as the PR was closed or merged.

@wasupandceacar
Copy link
Contributor Author

Thanks for the fix! Can you run a quick make style on your branch?

done

@sgugger sgugger merged commit f49a345 into huggingface:main Jun 1, 2023
@wasupandceacar wasupandceacar deleted the fix_ReduceLROnPlateau_no_get_last_lr branch June 2, 2023 01:24
gojiteji pushed a commit to gojiteji/transformers that referenced this pull request Jun 5, 2023
…gface#23944)

* Fix 'ReduceLROnPlateau' object has no attribute 'get_last_lr'

* fix style
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
…gface#23944)

* Fix 'ReduceLROnPlateau' object has no attribute 'get_last_lr'

* fix style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'ReduceLROnPlateau' object has no attribute 'get_last_lr'
3 participants