Effectively allow encoder_outputs
input to be a tuple in pix2struct
#23932
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be consistent with the type hint
transformers/src/transformers/models/pix2struct/modeling_pix2struct.py
Line 1656 in fabe17a
Optional[Union[Tuple[Tuple[torch.FloatTensor]], OrderedDict]]
IMO) and follow what is done with other architectures.Otherwise, currently, with
return_dict=True
, an error is raised as we later try to accessencoder_outputs.last_hidden_state
:transformers/src/transformers/models/pix2struct/modeling_pix2struct.py
Lines 1768 to 1781 in fabe17a
This is blocking for the ONNX export support.