Fix: Change tensors to integers for torch.dynamo and torch.compile compatibility #23475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… torch.compile compatibility
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
approved these changes
May 19, 2023
There was a problem hiding this comment.
LGTM, maybe @amyeroberts you could have a second look?
Can you run make fix-copies on your branch to fix the issue with the repo consistency check?
|
You undid your changes, you will need to make them in the file that mas2former copies from 😅 |
|
Oh bummer! Thank you for your patience. I will try to fix it. |
amyeroberts
approved these changes
May 19, 2023
sheonhan
pushed a commit
to sheonhan/transformers
that referenced
this pull request
Jun 1, 2023
…mpatibility (huggingface#23475) * Fix: Change tensors to integers in torch.split() for torch.dynamo and torch.compile compatibility * Applied the suggested fix to the utils/check_copies.py test * Applied the suggested fix by changing the original function that gets copied
gojiteji
pushed a commit
to gojiteji/transformers
that referenced
this pull request
Jun 5, 2023
…mpatibility (huggingface#23475) * Fix: Change tensors to integers in torch.split() for torch.dynamo and torch.compile compatibility * Applied the suggested fix to the utils/check_copies.py test * Applied the suggested fix by changing the original function that gets copied
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
…mpatibility (huggingface#23475) * Fix: Change tensors to integers in torch.split() for torch.dynamo and torch.compile compatibility * Applied the suggested fix to the utils/check_copies.py test * Applied the suggested fix by changing the original function that gets copied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes errors when trying to use PyTorch 2.0 torch.compile().
In the two fixes I suggested, we addressed the following issue:
torch.split() was expecting a list of integers specifying how to split the tensor along a given dimension. However, it received a list of scalar tensors instead. This mismatch was causing the TorchRuntimeError.
In the first instance, the tensor value_spatial_shapes was passed to the function as a list of scalar tensors, which resulted in the error. By converting them to integers using the .item() method, the error was resolved.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@amyeroberts @sgugger