Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate: increase left-padding test atol #23448

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Generate: increase left-padding test atol #23448

merged 1 commit into from
Jun 7, 2023

Conversation

gante
Copy link
Member

@gante gante commented May 18, 2023

What does this PR do?

As stated in #23437, GPTBigCode was failing the left padding test. Upon further investigation:

  1. GPTBigCode is left padding compatible, it accepts position_ids and uses them correctly
  2. The test is only failing on CPU
  3. The diff extremely small...

...so I've raised atol to 1e-7 (instead of the default 1e-8) 👀 With 1e-7, we can still detect failing cases, like the ones skipped in #23437

@gante gante requested review from ydshieh and amyeroberts May 18, 2023 11:23
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 18, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

amyeroberts
amyeroberts approved these changes May 18, 2023
View reviewed changes
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

I think 1e-7 is still very much in the realms of reasonable difference :)

@gante gante merged commit 612b2a1 into huggingface:main Jun 7, 2023
@gante gante deleted the starcoder_left_padding_test branch June 7, 2023 10:57
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
@gante @novice03
Generate: increase left-padding test atol (huggingface#23448)
df895a9 
increase atol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyeroberts amyeroberts amyeroberts approved these changes

@ydshieh ydshieh Awaiting requested review from ydshieh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gante @HuggingFaceDocBuilderDev @amyeroberts