Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RwkvModel #23392

Merged
merged 1 commit into from
May 16, 2023
Merged

Fix RwkvModel #23392

merged 1 commit into from
May 16, 2023

Conversation

ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented May 16, 2023

What does this PR do?

The convention is to filter out the None value from the output tuple.

And without this, torchscript tests fail as it doesn't like None value.

@ydshieh ydshieh requested a review from amyeroberts May 16, 2023 09:52
Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 16, 2023

The documentation is not available anymore as the PR was closed or merged.

@ydshieh ydshieh merged commit d765717 into main May 16, 2023
@ydshieh ydshieh deleted the fix_rwkv branch May 16, 2023 10:14
sheonhan pushed a commit to sheonhan/transformers that referenced this pull request Jun 1, 2023
gojiteji pushed a commit to gojiteji/transformers that referenced this pull request Jun 5, 2023
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants