Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes in transformers-tools #23364

Merged
merged 2 commits into from
May 16, 2023
Merged

Minor fixes in transformers-tools #23364

merged 2 commits into from
May 16, 2023

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented May 15, 2023

Really just a few things as I dig a bit into the implementation of transformers-tools:

  • upload_folder instead of os.listdir + create_commit (more robust against recursion)
  • some typing
  • use metadata_update with correct repo_id when pushing to Hub
  • use build_hf_headers instead of HfFolder for token retrieval
  • use super().__init__() and super().setup() in PipelineTool (otherwise the pipeline is setup again at each run)

@Wauplin Wauplin requested review from LysandreJik and sgugger May 15, 2023 09:11
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 15, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the fixes!

@Wauplin Wauplin merged commit 52d516c into main May 16, 2023
@Wauplin Wauplin deleted the tf-tools-minor-fixes branch May 16, 2023 13:55
sheonhan pushed a commit to sheonhan/transformers that referenced this pull request Jun 1, 2023
* Few fixes in new Tools implementation

* code quality
gojiteji pushed a commit to gojiteji/transformers that referenced this pull request Jun 5, 2023
* Few fixes in new Tools implementation

* code quality
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
* Few fixes in new Tools implementation

* code quality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants