Unpin numba #23162
Merged
Unpin numba #23162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
sanchit-gandhi
force-pushed
the
bump-numpy-version
branch
2 times, most recently
from
13ff157 to
a066590
Compare
added 16 commits
May 22, 2023 16:50
sanchit-gandhi
force-pushed
the
bump-numpy-version
branch
from
64bf551 to
67da5f1
Compare
|
Failing test is unrelated (tf compile test) |
sanchit-gandhi
commented
May 22, 2023
| @@ -116,7 +116,7 @@ def test_retrieve(self): | |||
| retriever = self.get_dummy_retriever() | |||
| tokenizer = retriever.tokenizer | |||
|
|
|||
| retrieved_block_ids = np.array([0, 3], dtype=np.long) | |||
| retrieved_block_ids = np.array([0, 3], dtype="long") | |||
There was a problem hiding this comment.
np.long is also deprecated in favour of dtype="long"
4 tasks
sheonhan
pushed a commit
to sheonhan/transformers
that referenced
this pull request
Jun 1, 2023
* fix for ragged list * unpin numba * make style * np.object -> object * propagate changes to tokenizer as well * np.long -> "long" * revert tokenization changes * check with tokenization changes * list/tuple logic * catch numpy * catch else case * clean up * up * better check * trigger ci * Empty commit to trigger CI
gojiteji
pushed a commit
to gojiteji/transformers
that referenced
this pull request
Jun 5, 2023
* fix for ragged list * unpin numba * make style * np.object -> object * propagate changes to tokenizer as well * np.long -> "long" * revert tokenization changes * check with tokenization changes * list/tuple logic * catch numpy * catch else case * clean up * up * better check * trigger ci * Empty commit to trigger CI
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
* fix for ragged list * unpin numba * make style * np.object -> object * propagate changes to tokenizer as well * np.long -> "long" * revert tokenization changes * check with tokenization changes * list/tuple logic * catch numpy * catch else case * clean up * up * better check * trigger ci * Empty commit to trigger CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Numba was pinned to <0.57.0 in #23118 - this is because it forced an update of the numpy package to >= 1.24. From numpy >= 1.24, converting a ragged list to a numpy array requires the user to explicitly set
dtype=object(before this happened automatically, but threw a deprecation warning).This PR updates the feature extraction and tokenisation utils to explicitly specify
dtype=objectwhen converting ragged lists to numpy arrays.