Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 [i18n-KO] Translated asr.mdx to Korean #23106

Merged
merged 4 commits into from
May 16, 2023
Merged

Conversation

sim-so
Copy link
Contributor

@sim-so sim-so commented May 2, 2023

What does this PR do?

Translated the asr.mdx file of the documentation to Korean.
Thank you in advance for your review.

Part of #20179

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Team PseudoLab, may you please review this PR?
@0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

@sgugger, @ArthurZucker, @eunseojo May you please review this PR?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 2, 2023

The documentation is not available anymore as the PR was closed or merged.

docs/source/ko/tasks/asr.mdx Outdated Show resolved Hide resolved
docs/source/ko/tasks/asr.mdx Outdated Show resolved Hide resolved
docs/source/ko/tasks/asr.mdx Outdated Show resolved Hide resolved
docs/source/ko/tasks/asr.mdx Outdated Show resolved Hide resolved
docs/source/ko/tasks/asr.mdx Outdated Show resolved Hide resolved
docs/source/ko/tasks/asr.mdx Outdated Show resolved Hide resolved
docs/source/ko/tasks/asr.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@0525hhgus 0525hhgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 번역 감사합니다 👍
사전에 설명해주셔서 개념과 용어를 이해하기 수월하네요! 아래 리뷰를 남겼습니다 😀

docs/source/ko/tasks/asr.mdx Outdated Show resolved Hide resolved
docs/source/ko/tasks/asr.mdx Outdated Show resolved Hide resolved
docs/source/ko/tasks/asr.mdx Outdated Show resolved Hide resolved
docs/source/ko/tasks/asr.mdx Outdated Show resolved Hide resolved
Copy link
Contributor Author

@sim-so sim-so left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

성모님이 제안해주신 수정 사항을 반영합니다!

docs/source/ko/tasks/asr.mdx Outdated Show resolved Hide resolved
docs/source/ko/tasks/asr.mdx Outdated Show resolved Hide resolved
docs/source/ko/tasks/asr.mdx Outdated Show resolved Hide resolved
docs/source/ko/tasks/asr.mdx Outdated Show resolved Hide resolved
docs/source/ko/tasks/asr.mdx Outdated Show resolved Hide resolved
Co-authored-by: Hyeonseo Yun <[email protected]>
@sim-so
Copy link
Contributor Author

sim-so commented May 15, 2023

Hope you have a great week!
Could you please review this PR?
@sgugger, @ArthurZucker, @eunseojo

@sim-so sim-so marked this pull request as ready for review May 16, 2023 06:22
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@sgugger sgugger merged commit 728c5e8 into huggingface:main May 16, 2023
@sim-so sim-so deleted the ko-asr branch May 28, 2023 00:16
sheonhan pushed a commit to sheonhan/transformers that referenced this pull request Jun 1, 2023
* docs: ko: task/asr.mdx

* feat: manual draft

* fix: resolve suggestions

Co-authored-by: Hyeonseo Yun <[email protected]>

---------

Co-authored-by: Hyeonseo Yun <[email protected]>
gojiteji pushed a commit to gojiteji/transformers that referenced this pull request Jun 5, 2023
* docs: ko: task/asr.mdx

* feat: manual draft

* fix: resolve suggestions

Co-authored-by: Hyeonseo Yun <[email protected]>

---------

Co-authored-by: Hyeonseo Yun <[email protected]>
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
* docs: ko: task/asr.mdx

* feat: manual draft

* fix: resolve suggestions

Co-authored-by: Hyeonseo Yun <[email protected]>

---------

Co-authored-by: Hyeonseo Yun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants