Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Japanese translation installation.mdx #21241

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Add Japanese translation installation.mdx #21241

merged 2 commits into from
Jan 23, 2023
+242 −0

Conversation

kambehmw
Copy link
Contributor

@kambehmw kambehmw commented Jan 22, 2023 •
edited by younesbelkada
Loading

What does this PR do?

Adds Japanese translation to installation.mdx

Partially addresses #18413

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@omarespejel @sgugger

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jan 22, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

ArthurZucker
ArthurZucker approved these changes Jan 23, 2023
View reviewed changes
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! can you check too @younesbelkada

younesbelkada
younesbelkada approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the translation! Left a small nit, otherwise LGTM

docs/source/ja/installation.mdx Outdated Show resolved Hide resolved
@younesbelkada younesbelkada mentioned this pull request Jan 23, 2023
Closed
10 tasks
@ArthurZucker ArthurZucker merged commit 9291116 into huggingface:main Jan 23, 2023
@kambehmw kambehmw deleted the add-ja-translation-to-installation.mdx branch January 23, 2023 14:44
miyu386 pushed a commit to miyu386/transformers that referenced this pull request Feb 9, 2023
@kambehmw @miyu386
Add Japanese translation installation.mdx (huggingface#21241)
5bd1429 
* Add Japanese translation installation.mdx

* Fixed for consistency with english version
ArthurZucker pushed a commit to ArthurZucker/transformers that referenced this pull request Mar 2, 2023
@kambehmw @ArthurZucker
Add Japanese translation installation.mdx (huggingface#21241)
b63ac11 
* Add Japanese translation installation.mdx

* Fixed for consistency with english version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@younesbelkada younesbelkada younesbelkada approved these changes

@ArthurZucker ArthurZucker ArthurZucker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kambehmw @HuggingFaceDocBuilderDev @ArthurZucker @younesbelkada