Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request] Whisper with language support #95

Closed
jozefchutka opened this issue Apr 20, 2023 · 2 comments
Closed

[Feature request] Whisper with language support #95

jozefchutka opened this issue Apr 20, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@jozefchutka
Copy link

jozefchutka commented Apr 20, 2023 •
edited
Loading

I am having hard times making whisper models (ie. base, not base.en) useful for any other language than English. Looking into sources I observed a few potentially related TODOs:

Could these please be resolved?

I wonder if there is any other way in current transfromres.js to define input language.
@jozefchutka jozefchutka added the enhancement New feature or request label Apr 20, 2023
@xenova
Copy link
Collaborator

xenova commented Apr 24, 2023

Linked to #87

Will be added soon! :)

xenova added a commit that referenced this issue Jun 5, 2023
@xenova
Add multilingual transcription + translation for whisper models (#87, #…
29bbfe5 
…95)
@xenova
Copy link
Collaborator

xenova commented Jun 5, 2023 •
edited
Loading

Opened PR for this 👍 Expect it to be merged soon.

xenova added a commit that referenced this issue Jun 9, 2023
@xenova
Add multilingual transcription + translation for whisper models (#87, #…
8625f4a 
…95) (#133)

* Align `.generate()` return type with python library

* Add multilingual transcription + translation for whisper models (#87, #95)

* Include `return_timestamps` in calculation of `forced_decoder_ids`

* Only return non-null `forced_decoder_ids`

* Allow user to specify task in any case

* Only set `forced_decoder_ids` when non-empty

* Implement `SuppressTokensAtBeginLogitsProcessor`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jozefchutka @xenova