feat: add default prompts #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 27, 2024
This was referenced Jul 1, 2024
Wauplin
added a commit
to huggingface/huggingface.js
that referenced
this pull request
Jul 12, 2024
This PR adds a script to import `feature-extraction` inference types from [text-embeddings-inference](https://github.com/huggingface/text-embeddings-inference). The jsonschema is pulled from https://huggingface.github.io/text-embeddings-inference/openapi.json and converted into the JSONSchema format from which we generate types from the JS and Python clients. This script is highly inspired on the TGI importer script. This PR also add `prompt_name` input parameter that has been newly added to TEI (see huggingface/text-embeddings-inference#312). Decisions taken: 1. Keep `string` as input. In theory TEI is capable of handling much more complex inputs (`Union[List[Union[List[int], int, str]], str]`) but let's keep it simple for now. Other inference tasks are also currently defined without arrays even when InferenceAPI/Endpoints is capable of it. 2. I only take input/output types for the `/embed` route, which is the closest one to `feature-extraction` task. **Note:** in a follow-up PR it would be really nice to put this in a CI workflow that could be triggered manually to open a PR when new arguments are added to TGI / TEI.
MasakiMu319
pushed a commit
to MasakiMu319/text-embeddings-inference
that referenced
this pull request
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #244