Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving bf16 tests #507

Merged
merged 44 commits into from
Jul 31, 2024
Merged

Improving bf16 tests #507

merged 44 commits into from
Jul 31, 2024

Conversation

Narsil
Copy link
Collaborator

@Narsil Narsil commented Jul 26, 2024

What does this PR do?

Fixes # (issue) or description of the problem this PR solves.

@Narsil Narsil force-pushed the improving_bf16_tests branch from 0542453 to bfabee2 Compare July 29, 2024 10:19
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for walking me through!

@Narsil Narsil merged commit c00471e into main Jul 31, 2024
11 checks passed
@Narsil Narsil deleted the improving_bf16_tests branch July 31, 2024 08:07
@kiszk
Copy link
Contributor

kiszk commented Jul 31, 2024

@Narsil Thanks very much for your work. The latest main after merging #507 works correctly. I confirmed it on s390x by running:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants