TST: Update Llava model id in test #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently PEFT tests are failing because 2 trl internal models that we relied on for testing were moved (one has also been changed). The new models have now been copied to peft-internal-testing to avoid this in the future. I have updated peft-internal-testing/tiny_T5ForSeq2SeqLM-lora to use the new copied model in peft-internal-testing as the base model (no change in PEFT code necessary). This model also required the LoRA adapter to be updated, as the shapes of the base model were changed. This PR updates the used Llava model id to now use the copy of that model that is inside of peft-internal-testing.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
githubnemo
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently PEFT tests are failing because 2 trl internal models that we relied on for testing were moved (one has also been changed). The new models have now been copied to
peft-internal-testingto avoid this in the future.I have updated
peft-internal-testing/tiny_T5ForSeq2SeqLM-lorato use the new copied model inpeft-internal-testingas the base model (no change in PEFT code necessary). This model also required the LoRA adapter to be updated, as the shapes of the base model were changed.This PR updates the used Llava model id to now use the copy of that model that is inside of
peft-internal-testing.