Use SFTConfig instead of SFTTrainer keyword args

[qgallouedec]

SFTTrainer's keyword args like packing, dataset_kwargs, dataset_text_field, max_seq_length has been deprecated and will be soon removed. Instead, we use SFTConfig (subclass of TrainingArguments)

This PR updates the code related to SFTTrainer.

[BenjaminBossan]

Thanks for addressing these trl deprecations. For my understanding, some arguments have been dropped without adding them to SFTConfig. Is that because for those, the default values were used?

[qgallouedec]

Which ones?

[BenjaminBossan]

Here would be an example where arguments are removed from SFTTrainer but no equivalent arguments were added to training_args.

[qgallouedec]

Ok I see what you mean.

When you run the script with, for example, --max_seq_length 123, the value will no longer feed data_args but training_args. Everything happens behind the scenes when arguments are parsed.

python example.py --output_dir tmp --max_seq_length 123

Before:

from dataclasses import dataclass
from typing import Optional
from transformers import HfArgumentParser, TrainingArguments

@dataclass
class DataTrainingArguments:
    dataset_name: Optional[str] = None
    max_seq_length: int = 512

if __name__ == "__main__":
    parser = HfArgumentParser((DataTrainingArguments, TrainingArguments))
    data_args, training_args = parser.parse_args_into_dataclasses()
    print(data_args.max_seq_length)  # 123

After:

from dataclasses import dataclass
from typing import Optional
from transformers import HfArgumentParser
from trl import SFTConfig

@dataclass
class DataTrainingArguments:
    dataset_name: Optional[str] = None

if __name__ == "__main__":
    parser = HfArgumentParser((DataTrainingArguments, SFTConfig))
    data_args, training_args = parser.parse_args_into_dataclasses()
    print(training_args.max_seq_length)  # 123

[HuggingFaceDocBuilderDev]

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

[BenjaminBossan]

Thanks for the PR and explaining the change. I tried the updated script and it worked. LGTM.