Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX [Docs/ bnb / DeepSpeed] Add clarification on bnb + PEFT + DS compatibilities #1529

Merged
merged 4 commits into from
Mar 5, 2024

Conversation

younesbelkada
Copy link
Contributor

as discussed offline and fixes #1418

cc @pacman100 @BenjaminBossan

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for testing and documenting this. Let's wait for Sourab's comment before merging.

Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Younes! ✨

@younesbelkada younesbelkada merged commit 98f4db2 into huggingface:main Mar 5, 2024
1 check passed
@younesbelkada younesbelkada deleted the add-ds-docs branch March 5, 2024 07:41
BenjaminBossan pushed a commit to BenjaminBossan/peft that referenced this pull request Mar 14, 2024
…S compatibilities (huggingface#1529)

* add clarification on bnb + PEFT + DS

* more clarification

* clarifications

* more clarification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation] Compatibility between lora + deepspeed + bitsandbytes
4 participants