[ Adaptation Prompt
] Fix llama rotary embedding issue with transformers main
#1459
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the adaptation prompt slow tests are failing on transformers main due to a recent refactor to add compatibility with static cache. huggingface/transformers#27931
That PR broke the adaptation prompt forward pass, as
module.rotary_emb
forward pass now haveposition_ids
as a required argument, thus breaking the current impmelementation of llama roatary embedding as we don't pass position_ids in PEFT.In addition, cos / sin are now directly indexed through that method, therefore we don't need to call our method that also indexes cos / sin with
positon_ids
. As computing the query states given cos / sin is a one-liner, I slighlty modified the logic inllama_compute_query_states
to make sure the forward pass works fine with transformers maincc @pacman100 @BenjaminBossan