Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: count params when zero init'd #140

Merged
merged 1 commit into from
Feb 27, 2023
Merged

fix: count params when zero init'd #140

merged 1 commit into from
Feb 27, 2023

Conversation

zanussbaum
Copy link
Contributor

Fix for #139, output now shows

trainable params: 3670016 || all params: 6054552800 || trainable%: 0.060615806339982696

for GPT-J

pacman100
pacman100 approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zanussbaum for fix, pretty neat ✨

@pacman100 pacman100 merged commit aa18556 into huggingface:main Feb 27, 2023
@dumpmemory
Copy link
Contributor

we might also need to change trainable_params += param.numel() to trainable_params += num_params

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacman100 pacman100 pacman100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zanussbaum @dumpmemory @pacman100