Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove HF tokens #1207

Merged
merged 1 commit into from
Dec 4, 2023
Merged

remove HF tokens #1207

merged 1 commit into from
Dec 4, 2023

Conversation

yxli2123
Copy link
Contributor

@yxli2123 yxli2123 commented Dec 4, 2023

Hi, I just found I leaked my personal HF tokens. I just removed and will deactivate it on my side.

younesbelkada
younesbelkada approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! is HF_TOKEN used anywhere else in the script?

BenjaminBossan
BenjaminBossan approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@BenjaminBossan BenjaminBossan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Note that the token will still be in the git history, so make 100% sure it's invalidated.

@yxli2123
Copy link
Contributor Author

yxli2123 commented Dec 4, 2023

No, there's only one defined but not used.

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@younesbelkada
Copy link
Contributor

OK thanks!

@younesbelkada younesbelkada merged commit 1b1091c into huggingface:main Dec 4, 2023
TaoSunVoyage pushed a commit to TaoSunVoyage/peft that referenced this pull request Dec 14, 2023
@yxli2123 @TaoSunVoyage
remove HF tokens (huggingface#1207)
4aaf30b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjaminBossan BenjaminBossan BenjaminBossan approved these changes

@younesbelkada younesbelkada younesbelkada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yxli2123 @HuggingFaceDocBuilderDev @younesbelkada @BenjaminBossan