Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ORTModel MRO for whisper #919

Merged

Conversation

fxmarty
Copy link
Contributor

@fxmarty fxmarty commented Mar 24, 2023

As per title, fixes #905, #906

This bug is introduced by huggingface/transformers#21252 that moves generate() implementation in WhisperForConditionalGeneration, hence breaking the inheritance order in transformers.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Mar 24, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@michaelbenayoun michaelbenayoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

optimum/exporters/onnx/__main__.py Outdated Show resolved Hide resolved
optimum/onnxruntime/modeling_seq2seq.py Outdated Show resolved Hide resolved
optimum/onnxruntime/modeling_seq2seq.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants