Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Tapas Model #520

Merged
merged 21 commits into from
Nov 30, 2022
Merged

Added support for Tapas Model #520

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
7939e13
Added support for Tapas Model
Nov 27, 2022
2db0d45
Merge branch 'huggingface:main' into Add-Bettertransformer-support-fo…
JuheonChu Nov 27, 2022
283186a
Added support for Tapas Model
Nov 27, 2022
b874831
Merge branch 'Add-Bettertransformer-support-for-Tapas' of https://git…
Nov 27, 2022
7c24a42
reformatted files with black
Nov 28, 2022
12d6154
Update tests/bettertransformer/test_bettertransformer_encoder.py
JuheonChu Nov 28, 2022
14b35ca
Update optimum/bettertransformer/models/encoder_models.py
JuheonChu Nov 28, 2022
9632f98
Merge branch 'huggingface:main' into Add-Bettertransformer-support-fo…
JuheonChu Nov 28, 2022
d2e6ebb
Update tests/bettertransformer/test_bettertransformer_encoder.py
JuheonChu Nov 28, 2022
762a804
Styled optimum files
Nov 28, 2022
ba1079e
Merge branch 'Add-Bettertransformer-support-for-Tapas' of https://git…
Nov 28, 2022
4047267
Update optimum/bettertransformer/models/encoder_models.py
JuheonChu Nov 28, 2022
ac716cc
Update optimum/bettertransformer/models/encoder_models.py
JuheonChu Nov 28, 2022
add72dd
Merge branch 'huggingface:main' into Add-Bettertransformer-support-fo…
JuheonChu Nov 28, 2022
bbd625e
Update tests/bettertransformer/test_bettertransformer_encoder.py
JuheonChu Nov 29, 2022
fded9ac
Moved Tapas Encoder model to Encoder
JuheonChu Nov 29, 2022
7fcc616
change mapping in __init_.py
JuheonChu Nov 29, 2022
579f889
deleted
JuheonChu Nov 29, 2022
fe547eb
Update __init__.py
JuheonChu Nov 29, 2022
1d64709
Update __init__.py
JuheonChu Nov 29, 2022
64e644c
refactor doc + remove class + styling
younesbelkada Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion optimum/bettertransformer/models/encoder_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
from .base import BetterTransformerBaseLayer


class TapasLayerBetterTransformer(BetterTransformerBaseLayer):
def __init__(self, tapas_layer, config):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to remove the class TapasLayerBetterTransformer in full 😅 It is not needed in the end since BertLayerBetterTransformer can handle Tapas.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I removed class TapasLayerBetterTransformer. Is there anything to be adjusted in this file?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On your branch, with optimum dev installed (pip install -e . in the optimum top folder), can you try to run the script @younesbelkada provided you and see what happens?

from transformers import AutoModel
from optimum.bettertransformer import BetterTransformer

model_id = "hf-internal-testing/tiny-random-TapasModel"
model = AutoModel.from_pretrained(model_id)
bt_model = BetterTransformer.transform(model)

r"""
A simple conversion of the TAPAS layer to its `BetterTransformer` implementation.
Expand Down