Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add padding_idx to appropriate embedding split #403

Merged
merged 6 commits into from
May 31, 2023
Merged

Add padding_idx to appropriate embedding split #403

merged 6 commits into from
May 31, 2023

Conversation

hmellor
Copy link
Member

@hmellor hmellor commented May 31, 2023 •
edited
Loading

What does this PR do?

Fixes bug in SerializedEmbedding where it is assumed that the padding_idx will be on the 0th embedding split

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 31, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@katalinic-gc katalinic-gc merged commit 97c11c3 into huggingface:main May 31, 2023
@katalinic-gc katalinic-gc deleted the fix-serialized-embedding branch May 31, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katalinic-gc katalinic-gc katalinic-gc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hmellor @HuggingFaceDocBuilderDev @katalinic-gc