Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deberta/translation/summarization notebook fixes #396

Merged
merged 2 commits into from
May 23, 2023
Merged

deberta/translation/summarization notebook fixes #396

merged 2 commits into from
May 23, 2023

Conversation

kundaMwiza
Copy link
Contributor

What does this PR do?

  • Deberta notebook should call parallelize on the pipelined model
  • Generation max length training argument is required otherwise the default value of 20 tokens will give low evaluation scores

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 23, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@kundaMwiza kundaMwiza changed the title Notebook fixes deberta/translation/summarization notebook fixes May 23, 2023
@jimypbr jimypbr merged commit 0410b16 into huggingface:main May 23, 2023
@jimypbr jimypbr deleted the notebook-fixes branch May 23, 2023 10:30
jimypbr pushed a commit that referenced this pull request May 23, 2023
@kundaMwiza @jimypbr
deberta/translation/summarization notebook fixes (#396)
a53c030 
* Deberta notebook: pipelined model needs to be parallelized for correct  execution on the IPU
* Notebooks translation & summarization: provide generation max length (default is 20)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimypbr jimypbr jimypbr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kundaMwiza @HuggingFaceDocBuilderDev @jimypbr