Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a faster torch based version of the whisper feature extractor #376

Merged
merged 1 commit into from
May 18, 2023
Merged

Add a faster torch based version of the whisper feature extractor #376

merged 1 commit into from
May 18, 2023

Conversation

katalinic-gc
Copy link
Collaborator

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented May 11, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

@katalinic-gc katalinic-gc changed the title Add a faster torch based version of the whisper feature extractor WIP: Add a faster torch based version of the whisper feature extractor May 11, 2023
@katalinic-gc katalinic-gc changed the title WIP: Add a faster torch based version of the whisper feature extractor Draft: Add a faster torch based version of the whisper feature extractor May 11, 2023
@katalinic-gc katalinic-gc marked this pull request as draft May 11, 2023 16:35
@katalinic-gc katalinic-gc force-pushed the whisper_subclass_featext branch from fb291a8 to 56db9ff Compare May 12, 2023 13:56
@katalinic-gc katalinic-gc marked this pull request as ready for review May 12, 2023 13:57
@katalinic-gc katalinic-gc changed the title Draft: Add a faster torch based version of the whisper feature extractor Add a faster torch based version of the whisper feature extractor May 12, 2023
jimypbr
jimypbr approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@jimypbr jimypbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge when ready

@katalinic-gc katalinic-gc merged commit db8d9f7 into huggingface:main May 18, 2023
@katalinic-gc katalinic-gc deleted the whisper_subclass_featext branch May 18, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimypbr jimypbr jimypbr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@katalinic-gc @HuggingFaceDocBuilderDev @jimypbr