Instantiate optimizer in compile only mode #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le only mode. self.train() will eventually make the call to self.create_optimizer()
|
The documentation is not available anymore as the PR was closed or merged. |
kundaMwiza
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
if the user does not provide an optimizer to the trainer class,
self.optimizer=Nonewithcompile onlymode. This is okay forTrainer.train()since it makes the call toself.create_optimizer(), which instantiates an optimizer if one does not exist. This PR ensures that an optimizer is instantiated even in compile only mode.Fixes # (issue)
Before submitting