Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sam notebook #409

Merged
merged 3 commits into from
Jul 11, 2023
Merged

Fix sam notebook #409

merged 3 commits into from
Jul 11, 2023

Conversation

younesbelkada
Copy link
Contributor

@younesbelkada younesbelkada commented Jul 11, 2023

What does this PR do?

Addresses huggingface/transformers#23295 (comment)

What are the changes?

  • change broken pull figure
  • change the installation from source to classic installation
  • replace all occurences of incorrect bounding box format to the correct one. In the previous notebook we were passing a list of lists, where in fact we should pass a list of list of lists.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@review-notebook-app
Copy link

review-notebook-app bot commented Jul 11, 2023

View / edit / reply to this conversation on ReviewNB

ArthurZucker commented on 2023-07-11T06:17:03Z
----------------------------------------------------------------

Could you highlight the main differences, the diff is a bit messed up


younesbelkada commented on 2023-07-11T06:30:06Z
----------------------------------------------------------------

Yes sure, the main differences are the following:

  • change broken pull figure
  • change the installation from source to classic installation
  • replace all occurences of incorrect bounding box format to the correct one. In the previous notebook we were passing a list of lists, where in fact we should pass a list of list of lists.

Overall that sould be pretty much it

Copy link
Contributor Author

Yes sure, the main differences are the following:

  • change broken pull figure
  • change the installation from source to classic installation
  • replace all occurences of incorrect bounding box format to the correct one. In the previous notebook we were passing a list of lists, where in fact we should pass a list of list of lists.

Overall that sould be pretty much it


View entire conversation on ReviewNB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant