Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use config dict in TaskConfigLogger for easier serialization #454

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Use config dict in TaskConfigLogger for easier serialization #454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
146b307
Use config asdict in TaskConfigLogger
albertvillanova Dec 18, 2024
ead56f1
Fix tasks_configs name in docstring
albertvillanova Dec 18, 2024
5ac5646
Rename tasks_configs to task_configs
albertvillanova Dec 18, 2024
c30727a
Merge branch 'main' into task-config-logger
albertvillanova Dec 19, 2024
d79aaa8
Merge branch 'main' of github.com:huggingface/lighteval into task-con…
albertvillanova Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lighteval/logging/evaluation_tracker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ def save(self) -> None:
"config_general": config_general,
"results": self.metrics_logger.metric_aggregated,
"versions": self.versions_logger.versions,
"config_tasks": self.task_config_logger.tasks_configs,
"config_tasks": self.task_config_logger.task_configs,
"summary_tasks": self.details_logger.compiled_details,
"summary_general": asdict(self.details_logger.compiled_details_over_all_tasks),
}
Expand Down Expand Up @@ -228,7 +228,7 @@ def generate_final_dict(self) -> dict:
"config_general": asdict(self.general_config_logger),
"results": self.metrics_logger.metric_aggregated,
"versions": self.versions_logger.versions,
"config_tasks": self.task_config_logger.tasks_configs,
"config_tasks": self.task_config_logger.task_configs,
"summary_tasks": self.details_logger.compiled_details,
"summary_general": asdict(self.details_logger.compiled_details_over_all_tasks),
}
Expand Down
12 changes: 6 additions & 6 deletions src/lighteval/logging/info_loggers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
from lighteval.metrics.stderr import get_stderr_function
from lighteval.models.abstract_model import ModelInfo
from lighteval.models.model_output import ModelResponse
from lighteval.tasks.lighteval_task import LightevalTask, LightevalTaskConfig
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we using the LightevalTaskConfig anywhere else ?

from lighteval.tasks.lighteval_task import LightevalTask
from lighteval.tasks.requests import Doc
from lighteval.utils.imports import is_nanotron_available
from lighteval.utils.utils import as_list, sanitize_numpy
Expand Down Expand Up @@ -589,15 +589,15 @@ class TaskConfigLogger:
"""Logs the different parameters of the current [`LightevalTask`] of interest.

Attributes:
tasks_config (dict[str, LightevalTaskConfig]): Maps each task to its associated [`LightevalTaskConfig`]
task_configs (dict[str, dict]): Maps each task to its associated [`LightevalTaskConfig`] dict.

"""

tasks_configs: dict[str, LightevalTaskConfig] = field(default_factory=dict)
task_configs: dict[str, dict] = field(default_factory=dict)

def log(self, task_dict: dict[str, LightevalTask]) -> None:
self.tasks_configs = {name: task.cfg for name, task in task_dict.items()}
self.task_configs = {name: asdict(task.cfg) for name, task in task_dict.items()}

def log_num_docs(self, task_name: str, original_num_docs: int, effective_num_docs: int) -> None:
self.tasks_configs[task_name].original_num_docs = original_num_docs
self.tasks_configs[task_name].effective_num_docs = effective_num_docs
self.task_configs[task_name]["original_num_docs"] = original_num_docs
self.task_configs[task_name]["effective_num_docs"] = effective_num_docs
Loading