Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support python 3.12 #2605

Merged
merged 9 commits into from
Oct 15, 2024
Merged

Support python 3.12 #2605

merged 9 commits into from
Oct 15, 2024

Conversation

hanouticelina
Copy link
Contributor

@hanouticelina hanouticelina commented Oct 14, 2024 •
edited
Loading

changes made

  • run CI on Python 3.12.
  • run torch~=1.11 only on python 3.8.
  • pin new supported version in setup.py.
  • update documentation.

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

julien-c
julien-c reviewed Oct 14, 2024
View reviewed changes
Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(btw python latest is 3.13 no? but not sure if the ML backends support it yet? though pytorch should work with latest python no?)

@hanouticelina
Copy link
Contributor Author

@julien-c indeed, a stable version of python 3.13.0 was released last week https://www.python.org/downloads/release/python-3130/ but tensorflow and torch are not supporting python 3.13 yet

@Wauplin
Copy link
Contributor

Wauplin commented Oct 15, 2024 •
edited
Loading

Ahah true, I missed last year release 😄 Worth testing and officially supporting 3.13 then. ML frameworks are tested on lower versions anyway so shouldn't be a problem.

@hanouticelina hanouticelina changed the title Support python 3.12 Support python 3.12 & 3.13 Oct 15, 2024
@hanouticelina
Copy link
Contributor Author

The CI is green for python 3.12, let's bump the version to 3.13 and support it as well!

@hanouticelina hanouticelina changed the title Support python 3.12 & 3.13 Support python 3.12 Oct 15, 2024
@hanouticelina
Copy link
Contributor Author

issues with gradio support for python 3.13 (gradio/issues/9696) :( we will only support python 3.12 for now and then bump to 3.13 once the issue is fixed.

@hanouticelina hanouticelina requested a review from Wauplin October 15, 2024 13:20
Wauplin
Wauplin approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@hanouticelina hanouticelina merged commit 9bb6bd6 into main Oct 15, 2024
16 checks passed
@hanouticelina hanouticelina deleted the support-python-3-12 branch October 15, 2024 13:40
@hanouticelina hanouticelina mentioned this pull request Oct 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-c julien-c julien-c left review comments

@Wauplin Wauplin Wauplin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hanouticelina @HuggingFaceDocBuilderDev @Wauplin @julien-c