Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated index.md and installation.md to Tamil #2555

Merged
merged 6 commits into from
Oct 16, 2024

Conversation

Raghul-M
Copy link
Contributor

What is this PR about ?

I translated the following files to tamil :

  • toctree.yml
  • index.md
  • installation.md

issue: #1901

@Wauplin @stevhliu

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Would you happen to know another contributor who can review the translated content? I can't read Tamil so unfortunately, I can't review that part of your PR.

Finally, you'll need to add the language code here and here to build the docs!

docs/source/tm/index.md Outdated Show resolved Hide resolved

<a class="!no-underline border dark:border-gray-700 p-5 rounded-lg shadow hover:shadow-lg" href="./guides/overview">
<div class="w-full text-center bg-gradient-to-br from-indigo-400 to-indigo-500 rounded-lg py-1.5 font-semibold mb-5 text-white text-lg leading-relaxed">How-to guides</div>
<p class="text-gray-700">Practical guides to help you achieve a specific goal. Take a look at these guides to learn how to use huggingface_hub to solve real-world problems.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be amazing if the text here is also translated!

நீங்கள் விருப்பத் தேவைப்படும் சார்புகளை `pip` மூலம் நிறுவலாம்:

```bash
# Install dependencies for tensorflow-specific features
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Translating the code comments would also make it easier for native readers to read :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

especially because in this case the comment is also shown to the end reader (see here)
image

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Raghul-M
Copy link
Contributor Author

@stevhliu How do I add a new reviewer to review my translated content?

@Wauplin
Copy link
Contributor

Wauplin commented Oct 14, 2024

@Raghul-M no need to add them "officially". I you know people that would be interested in reviewing it, you can just tag them in a comment kindly asking for their review. They can then go to https://github.com/huggingface/huggingface_hub/pull/2555/files and do the proper review 🤗

@Raghul-M
Copy link
Contributor Author

@lovelindhoni Can you review it

@lovelindhoni
Copy link

Sure, @Raghul-M

Copy link

@lovelindhoni lovelindhoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. Great job

@Raghul-M Raghul-M requested review from stevhliu and Wauplin October 16, 2024 07:49
Copy link
Contributor

@Wauplin Wauplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thanks @Raghul-M @lovelindhoni for starting this work! Let's merge this piece now 🤗

@Wauplin Wauplin merged commit 8d9409d into huggingface:main Oct 16, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants