Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh workflows support --not_python_module flag #153

Merged
merged 3 commits into from
Mar 25, 2022
Merged

Gh workflows support --not_python_module flag #153

merged 3 commits into from
Mar 25, 2022

Conversation

mishig25
Copy link
Contributor

so that we can use GH templates in course new frontend Ci here

Copy link
Contributor

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! I think we can make the new arg more general.

Comment on lines 16 to 17
# supply --not_python_module for HF Course
module_flag:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd call this additional_args so we can use it to pass anything.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, 35a58fa

Comment on lines 17 to 20
# supply --not_python_module for HF Course
module_flag:
type: string
default: ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments on this file.

@mishig25 mishig25 requested a review from sgugger March 25, 2022 01:17
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition, thanks @mishig25!

@mishig25
Copy link
Contributor Author

Thanks a lot fir the reviews 😊 merging it since trying to get the doc-build asap

1 similar comment
@mishig25
Copy link
Contributor Author

Thanks a lot fir the reviews 😊 merging it since trying to get the doc-build asap

@mishig25 mishig25 merged commit af4cae2 into main Mar 25, 2022
@mishig25 mishig25 deleted the module_flag branch March 25, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants