[chore] fix: retain memory utility. #9543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
a-r-r-o-w
approved these changes
Sep 28, 2024
|
I had a different meaning in mind, don't know why. But I get your point. Will rename to |
leisuzz
pushed a commit
to leisuzz/diffusers
that referenced
this pull request
Oct 11, 2024
* fix: retain memory utility. * fix * quality * free_memory.
sayakpaul
added a commit
that referenced
this pull request
Dec 23, 2024
* fix: retain memory utility. * fix * quality * free_memory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
My bad that in
diffusers/src/diffusers/training_utils.py
Line 263 in 534848c
I assumed that the scope of
delwould carry forward but that is not the case. So, even when we calldel objit actually just deletes the local reference, it doesn't carry forward. So, we're better off without it and doingdelexplicitly (like the changes done in this PR).Thanks to @a-r-r-o-w for catching this. It didn't go to a release yet, so, I think this shouldn't have any issues.