-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature flux controlnet img2img and inpaint pipeline #9408
Feature flux controlnet img2img and inpaint pipeline #9408
Conversation
Hey @a-r-r-o-w can you suggest if the flux img2img controlnet pipeline needs any fix or if this architecture is fine to go with. |
src/diffusers/pipelines/flux/pipeline_flux_controlnet_image_to_image.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
awesome! thank you! |
can you run |
Sure I will! |
…nd added copied to prepare_latents in img2img pipeline
Here is example for img2img - diffusers/src/diffusers/pipelines/flux/pipeline_flux_controlnet_image_to_image.py Line 42 in a30ca65
Here is example for inpaint -
|
@yiyixuxu any updates, are we good to go or does it require further changes |
can we look into the failing fast tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, the PR looks very clean and everything seems right! Great work @ighoshsubho
Just some minor nits from me. Could you also add these pipelines to the flux docs and address the failing tests?
Btw @yiyixuxu, do we need the slow integration tests here? I think we don't have them on derived pipelines that are made from two or more components (such as Flux + ImageToImage, or AnimateDiff + VideoToVideo)
src/diffusers/pipelines/flux/pipeline_flux_controlnet_image_to_image.py
Outdated
Show resolved
Hide resolved
src/diffusers/pipelines/flux/pipeline_flux_controlnet_inpainting.py
Outdated
Show resolved
Hide resolved
will address the tests and minor fixes quick update, @a-r-r-o-w and @yiyixuxu I found a small bug in my inpaint controlnet pipeline for which the tests are failing will address this by today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two more change requests
@yiyixuxu and @a-r-r-o-w fixed the minor bugs and tests should pass now |
Can't wait for this awesomeness!!!! |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
thank you! |
Thank you @ighoshsubho |
* Implemented FLUX controlnet support to Img2Img pipeline
How can I use other controlnets, such as XLabs-AI/flux-controlnet-canny-v3? The canny model in the example exceeds my vmem |
* Implemented FLUX controlnet support to Img2Img pipeline
What does this PR do?
Fixes #9402 and #9158
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.