Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature flux controlnet img2img and inpaint pipeline #9408

Merged

Conversation

ighoshsubho
Copy link
Contributor

What does this PR do?

Fixes #9402 and #9158

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ighoshsubho
Copy link
Contributor Author

Hey @a-r-r-o-w can you suggest if the flux img2img controlnet pipeline needs any fix or if this architecture is fine to go with.

@ighoshsubho ighoshsubho changed the title Feature flux controlnet image to image pipeline Feature flux controlnet img2img and inpaint pipeline Sep 11, 2024
@ighoshsubho ighoshsubho marked this pull request as ready for review September 11, 2024 17:03
Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yiyixuxu
Copy link
Collaborator

awesome! thank you!
can you share example script + result from these two pipelines?

@yiyixuxu
Copy link
Collaborator

can you run make style and fix copies so CI can pass?

@ighoshsubho
Copy link
Contributor Author

awesome! thank you!
can you share example script + result from these two pipelines?

Sure I will!

@ighoshsubho
Copy link
Contributor Author

awesome! thank you! can you share example script + result from these two pipelines?

awesome! thank you! can you share example script + result from these two pipelines?

Here is example for img2img -

Here is example for inpaint -

@ighoshsubho
Copy link
Contributor Author

@yiyixuxu any updates, are we good to go or does it require further changes

@yiyixuxu
Copy link
Collaborator

can we look into the failing fast tests?

Copy link
Member

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, the PR looks very clean and everything seems right! Great work @ighoshsubho

Just some minor nits from me. Could you also add these pipelines to the flux docs and address the failing tests?

Btw @yiyixuxu, do we need the slow integration tests here? I think we don't have them on derived pipelines that are made from two or more components (such as Flux + ImageToImage, or AnimateDiff + VideoToVideo)

@ighoshsubho
Copy link
Contributor Author

ighoshsubho commented Sep 14, 2024

Thank you, the PR looks very clean and everything seems right! Great work @ighoshsubho

Just some minor nits from me. Could you also add these pipelines to the flux docs and address the failing tests?

Btw @yiyixuxu, do we need the slow integration tests here? I think we don't have them on derived pipelines that are made from two or more components (such as Flux + ImageToImage, or AnimateDiff + VideoToVideo)

will address the tests and minor fixes

quick update, @a-r-r-o-w and @yiyixuxu I found a small bug in my inpaint controlnet pipeline for which the tests are failing will address this by today

Copy link
Member

@a-r-r-o-w a-r-r-o-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two more change requests

docs/source/en/api/pipelines/flux.md Outdated Show resolved Hide resolved
docs/source/en/api/pipelines/flux.md Outdated Show resolved Hide resolved
@ighoshsubho
Copy link
Contributor Author

@yiyixuxu and @a-r-r-o-w fixed the minor bugs and tests should pass now

@mrtpk
Copy link

mrtpk commented Sep 17, 2024

Can't wait for this awesomeness!!!!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@yiyixuxu yiyixuxu merged commit bb1b0fa into huggingface:main Sep 17, 2024
15 checks passed
@yiyixuxu
Copy link
Collaborator

thank you!

@mrtpk
Copy link

mrtpk commented Sep 17, 2024

Thank you @ighoshsubho

leisuzz pushed a commit to leisuzz/diffusers that referenced this pull request Oct 11, 2024
* Implemented FLUX controlnet support to Img2Img pipeline
@DoiryCool
Copy link

How can I use other controlnets, such as XLabs-AI/flux-controlnet-canny-v3? The canny model in the example exceeds my vmem

sayakpaul pushed a commit that referenced this pull request Dec 23, 2024
* Implemented FLUX controlnet support to Img2Img pipeline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flux ControlNet] Add img2img and inpaint pipelines
6 participants