Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sentencepiece to requirements.txt for SD3 dreambooth #8538

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

jorahn
Copy link
Contributor

@jorahn jorahn commented Jun 13, 2024

add sentencepiece to requirements.txt for SD3 dreambooth

What does this PR do?

sd3 dreambooth requires sentencepiece but it's not in the requirements.

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@sayakpaul

add `sentencepiece` requirement
@sayakpaul
Copy link
Member

Could you resolve the conflicts?

@jorahn
Copy link
Contributor Author

jorahn commented Jun 13, 2024

Could you resolve the conflicts?

Let me check!

@jorahn
Copy link
Contributor Author

jorahn commented Jun 13, 2024

@sayakpaul done

@sayakpaul
Copy link
Member

@jorahn apologies for the trouble but could you push an empty commit to trigger the CI?

@jorahn
Copy link
Contributor Author

jorahn commented Jun 14, 2024

@sayakpaul do you need anything else? Don't think the build errors are related.

@sayakpaul sayakpaul merged commit a899e42 into huggingface:main Jun 14, 2024
1 check failed
@sayakpaul
Copy link
Member

Thank you!

sayakpaul added a commit that referenced this pull request Dec 23, 2024
* add `sentencepiece` requirement for SD3

add `sentencepiece` requirement

* Empty-Commit

---------

Co-authored-by: Sayak Paul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants