-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace torchsde dependency with torchsde-brownian #5192
Conversation
Hey @akx, Thanks for the PR! Just to better understand is there any functionality that is changed? If the PR stays exactly the same, I don't fully see the advantage of changing the package here tbh |
@patrickvonplaten The functionality (and the code, aside from import names of course) is exactly the same, but there's 70% less code (since the ODE parts of the
You can see how this came to be in akx/torchsde-brownian#1. There's also one less transitive dependency as This also ties in to the philosophy doc:
|
Anyway, there's also a secondary concern here since #3020 basically just copy-pasted the sampler from |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
De-staling. WDYT, @patrickvonplaten? |
@akx, I don't feel super comfortable replacing the dependency because torchsde is a robust, well-known library with >1K stars. I don't really mind that it has some additional functionality that we don't need |
@patrickvonplaten Thanks for getting back to me! As explained in the PR description and Either way, I suppose this PR is no longer quite as required now that torchsde==0.2.6 (likely the final ever version, given the comments above) is out after I fixed torchsde's CI process to let them release with confidence (google-research/torchsde#140). The secondary concern still stands: the sampler introduced in #3020 (that introduced the |
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
What does this PR do?
This PR replaces the
torchsde
dependency with my forktorchsde-brownian
that only includes the Brownian motion code that is required by thedpmpp_sde
sampler (that itself is lifted fromk-diffusion
(where there is a sibling PR crowsonkb/k-diffusion#82)) that was added in #3020.The fork also has one dependency less (
boltons
), though that change would also be in a future unreleased version oftorchsde
thanks to my PR over there.The implementation of this PR here is really just a search-and-replace.
Before submitting
torchsde
package.Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.