Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CogVideoX transformer forward #10789

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

a-r-r-o-w
Copy link
Member

Fixes #10566.

I overlooked this part during the integration. Since we're operating on the embedding dimension, there's no need to concatenate across the sequence dimension

@a-r-r-o-w a-r-r-o-w requested a review from yiyixuxu February 13, 2025 20:50
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@yiyixuxu yiyixuxu merged commit ab42820 into main Feb 13, 2025
15 checks passed
@yiyixuxu yiyixuxu deleted the refactor/cogvideox-transformer-layernorm branch February 13, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary operations in CogVideoXTransformer3DModel.forward()?
3 participants