-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] [tests] test encode_prompt()
in isolation
#10438
Draft
sayakpaul
wants to merge
21
commits into
main
Choose a base branch
from
tests-encode-prompt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@hlky now that the PRs have been merged to support this, let's brainstorm if this is how we want to test |
@DN6 a gentle ping. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
encode_prompt()
is often used in isolation to lift off memory requirements and to also compute prompt embeddings in many trainers. It's important that we testencode_prompt()
properly.This PR adds a test suite to do that. Since we cannot reliably map the outputs of
encode_prompt()
into keyword arguments of a pipeline call, I propose to use theast
module to determine the names of the variables returned from a particularencode_prompt()
method. This PR is a PoC of what the changes might look like at the test level.The closest test we have currently is this:
diffusers/tests/pipelines/test_pipelines_common.py
Line 2165 in 15d4569
But, IMO, this should be extended to the other pipelines on a more general level.
TODOs
encode_prompt()
to work in isolation in the pipelines if needed.SDXLOptionalComponentsTesterMixin
if needed.