Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update elasticsearch version #7300

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Conversation

ruidazeng
Copy link
Contributor

@ruidazeng ruidazeng commented Nov 28, 2024

This should fix the test_py311 (windows latest, deps-latest errors.

=========================== short test summary info ===========================
ERROR tests/test_search.py - AttributeError: `np.float_` was removed in the NumPy 2.0 release. Use `np.float64` instead.
ERROR tests/test_search.py - AttributeError: `np.float_` was removed in the NumPy 2.0 release. Use `np.float64` instead.
===== 2822 passed, 54 skipped, 10 warnings, 2 errors in 373.36s (0:06:13) =====
Error: Process completed with exit code 1.

The elasticsearch version used is elasticsearch==7.9.1, which is 4 years old and uses the removed numpy.float_.

elasticsearch fixed this in elastic/elasticsearch-py#2551 and released in 8.15.0 (August 2024) and 7.17.12 (September 2024).

@ruidazeng ruidazeng changed the title docs: update elasticsearch version fix: update elasticsearch version Nov 28, 2024
@ruidazeng ruidazeng marked this pull request as draft December 2, 2024 17:48
@ruidazeng ruidazeng marked this pull request as ready for review December 2, 2024 17:48
@ruidazeng
Copy link
Contributor Author

May I request a review @lhoestq

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks !

@lhoestq lhoestq merged commit 38d648e into huggingface:main Dec 3, 2024
14 checks passed
@ruidazeng ruidazeng deleted the patch-1 branch December 3, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants