Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed the translation of the first part of Chapter 7 into Russian. #653

Merged
merged 24 commits into from
Jan 11, 2024
Merged

Conversation

artyomboyko
Copy link
Contributor

#75

This is the first part of the translation of chapter 7 of the course. Since this chapter is very massive, it was decided to split the translation into two parts.

@MKhalusova I'm waiting for your review Maria)

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@MKhalusova MKhalusova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Left a few nits.

chapters/ru/chapter7/1.mdx Outdated Show resolved Hide resolved
chapters/ru/chapter7/2.mdx Outdated Show resolved Hide resolved
chapters/ru/chapter7/2.mdx Outdated Show resolved Hide resolved
chapters/ru/chapter7/2.mdx Outdated Show resolved Hide resolved
chapters/ru/chapter7/2.mdx Outdated Show resolved Hide resolved
chapters/ru/chapter7/5.mdx Outdated Show resolved Hide resolved
chapters/ru/chapter7/5.mdx Outdated Show resolved Hide resolved
chapters/ru/chapter7/5.mdx Outdated Show resolved Hide resolved
chapters/ru/chapter7/5.mdx Outdated Show resolved Hide resolved
chapters/ru/chapter7/5.mdx Outdated Show resolved Hide resolved
artyomboyko and others added 22 commits January 10, 2024 20:02
Extra space.

Co-authored-by: Maria Khalusova <[email protected]>
Extra space. I didn't notice.

Co-authored-by: Maria Khalusova <[email protected]>
Extra space. I didn't notice.

Co-authored-by: Maria Khalusova <[email protected]>
Yes, indeed, I ate the space bar)))))

Co-authored-by: Maria Khalusova <[email protected]>
There's that extra space again.

Co-authored-by: Maria Khalusova <[email protected]>
There's that extra space again that I didn't notice.

Co-authored-by: Maria Khalusova <[email protected]>
Extra space.

Co-authored-by: Maria Khalusova <[email protected]>
Translated the missing comment.
Extra space.

Co-authored-by: Maria Khalusova <[email protected]>
Translated the missing comment in the code
Translated the missing sentence.
Translated the missing sentence.
I agree, it sounds more neutral that way.
An unnecessary parenthesis.

Co-authored-by: Maria Khalusova <[email protected]>
Also an option, but we've translated it as "карточка модели" a lot of places.

Co-authored-by: Maria Khalusova <[email protected]>
Extra space.

Co-authored-by: Maria Khalusova <[email protected]>
Translated the missing comment in the code.
Extra sapce.

Co-authored-by: Maria Khalusova <[email protected]>
Extra space.

Co-authored-by: Maria Khalusova <[email protected]>
Translated the missing comment in the code.
Added and translated the missing sentence: "Since the collator expects a list of dicts, where each dict represents a single example in the dataset, we also need to wrangle the data into the expected format before passing it to the data collator:"
Edit the display of the table on the course page.
Copy link
Contributor Author

@artyomboyko artyomboyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MKhalusova All done. You can check)))

Copy link
Contributor

@MKhalusova MKhalusova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MKhalusova MKhalusova merged commit 489dcd7 into huggingface:main Jan 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants