Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full translation of chapter 6 of the course. #647

Merged
merged 31 commits into from
Jan 8, 2024
Merged

Full translation of chapter 6 of the course. #647

merged 31 commits into from
Jan 8, 2024

Conversation

artyomboyko
Copy link
Contributor

@artyomboyko artyomboyko commented Dec 21, 2023

#75

@MKhalusova

Good day Maria. Full translation of chapter 6 of the course. If you have any comments, tag me. I look forward to your review.

Minor fix.
Trying to solve the markup problem.
Correcting the syntax of some markup again)
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Contributor

@MKhalusova MKhalusova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this chapter! Overall, looks good to me, I left some minor nits.

chapters/ru/chapter6/1.mdx Show resolved Hide resolved
chapters/ru/chapter6/1.mdx Show resolved Hide resolved
chapters/ru/chapter6/2.mdx Show resolved Hide resolved
chapters/ru/chapter6/3.mdx Outdated Show resolved Hide resolved
chapters/ru/chapter6/3.mdx Outdated Show resolved Hide resolved
chapters/ru/chapter6/7.mdx Outdated Show resolved Hide resolved
chapters/ru/chapter6/7.mdx Outdated Show resolved Hide resolved
chapters/ru/chapter6/3.mdx Outdated Show resolved Hide resolved
chapters/ru/chapter6/3.mdx Outdated Show resolved Hide resolved
chapters/ru/chapter6/3.mdx Outdated Show resolved Hide resolved
artyomboyko and others added 6 commits December 22, 2023 22:15
Yes, that space is redundant here. You're right about that.

Co-authored-by: Maria Khalusova <[email protected]>
Extra space. I overlooked it. My mistake.

Co-authored-by: Maria Khalusova <[email protected]>
There's an extra space here. You're right.

Co-authored-by: Maria Khalusova <[email protected]>
There's an extra space here. You're right.

Co-authored-by: Maria Khalusova <[email protected]>
Yeah, there's no need for a space here.

Co-authored-by: Maria Khalusova <[email protected]>
Co-authored-by: Maria Khalusova <[email protected]>
artyomboyko and others added 5 commits December 22, 2023 22:32
Translated the comments noted on the review.
Translated the missing comments in the code.
Yes, an extra space.

Co-authored-by: Maria Khalusova <[email protected]>
Minor fix.

Co-authored-by: Maria Khalusova <[email protected]>
@artyomboyko
Copy link
Contributor Author

@MKhalusova If all comments are resolved, then we can make that PR?

@MKhalusova
Copy link
Contributor

Thank you for this massive work, and for your patience. It's good to merge now.

@MKhalusova MKhalusova merged commit 2c733c2 into huggingface:main Jan 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants