Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronous Chinese course update #498

Merged
merged 8 commits into from
Feb 19, 2023
Merged

Conversation

yaoqih
Copy link
Contributor

@yaoqih yaoqih commented Feb 12, 2023

Synchronize Course document updates according to chenglu#1
sha:f71cf6c3b4cb235bc75a14416c6e8a57fc3d00a7
sha date: 2023/01/06 00:02:26 UTC+8

yaoqih and others added 5 commits February 12, 2023 15:18
Update the Chinese Course document to
sha:f71cf6c3b4cb235bc75a14416c6e8a57fc3d00a7
sha date: 2023/01/06 00:02:26 UTC+8
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Feb 12, 2023

The documentation is not available anymore as the PR was closed or merged.

@chenglu
Copy link
Contributor

chenglu commented Feb 19, 2023

The Chinese translation of the course was submitted a while ago. However, the original (English) docs has been updated several times since then. Therefore, this PR aims to align the Chinese translation with the latest changes in the English version.

Thanks to @yaoqih for developing the script!

Going forward, we could consider iterating and refining this script into a general tool that performs an automatic version check of the English docs when contributors submit a localization PR.

If the English docs were changed during the period between when the translation was started and when it was submitted, the script / bot should give a diff results to the contributors (like post a comment to the PR), and suggestion them to update the corresponding translated docs.

cc/ @xianbaoqian @lewtun

@xianbaoqian
Copy link
Contributor

Great work!! Thanks a lot for your hard work @yaoqih and @chenglu !

@xianbaoqian xianbaoqian merged commit b03d1b1 into huggingface:main Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants