-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Japanese trasnlation of chapter 1 / 2 to 3 #363
Conversation
Awesome work! 🤗 |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
This is super cool ️🔥 I was thinking it could be nice to have examples in Japanese throughout the course, what do you think? Just a suggestion! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this great translation @blackdoor571 and welcome to the 🤗 community!
I think @fxmarty's idea to use Japanese models is nice, but probably best done directly in the notebooks to ensure the course content is 1-1 across languages. No need to do that yourself, but just making a note here for other translators :)
There's a small code styling issue with the PR - could you please install the requirements and run make style
?
@lewtun Makes sense. Here's an example of how it was done in the French translation, with comments: https://huggingface.co/course/fr/chapter1/3?fw=pt . Honestly I'm not fan of putting comments everywhere (everything feels like less readable), but I see the point where there may be readers not able to grasp examples in English. I agree we could keep everything in English and leave translated example in future notebooks though. |
Hey @blackdoor571 thanks for this great translation! We just merged #359 which created some merge conflicts on the |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Thank you very much @blackdoor571 for your great contribution!! Merging |
No description provided.