Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese translation of chapter 1/4 to 6 #360

Merged
merged 13 commits into from
Nov 10, 2022

Conversation

haruki-N
Copy link
Contributor

@haruki-N haruki-N commented Nov 3, 2022

I created three files translated into Japanese: 4, 5, and 6.mdx of chapter1.

@younesbelkada
Copy link
Contributor

younesbelkada commented Nov 3, 2022

Thanks a lot for the great translation!
As you can see a small test is failing, could you make sure to update the _toctree.yml as following ;) (you can check also here)
Screenshot 2022-11-03 at 14 34 30

Copy link

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤗 Great work! Thanks a lot 🇯🇵

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the great translation!
In terms of content, that looks great to me 🔥 ! As stated in #359 I am just waiting the moon-ci to be back, check the frontend results and we should be good to merge! 💪
Thanks a lot!

@lewtun
Copy link
Member

lewtun commented Nov 10, 2022

Hey @haruki-N thanks a lot for your translation 🤗 ! We just merged #359 which means there are some conflicts with the table of contents - would you mind resolving them and pushing again?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@younesbelkada
Copy link
Contributor

hey @haruki-N , I have addressed the issue!
Thanks again for the amazing contribution !!

@younesbelkada younesbelkada merged commit eeab1f0 into huggingface:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants