-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New front for gradio chapters #34
Conversation
Awesome!! cc @dawoodkhan82 |
Tested, works great. |
FYI I've integrated the changes on |
OK the docs are failing to build due to a strange error (does not happen on
Maybe @mishig25 can help us understand what's causing this when he gets back from vacation 😎 Edit: nevermind, I figured out what the problem was and fixed it in 351c4f9 |
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Should we merge now or wait until we've updated the content with gradio
v3?
@@ -167,6 +167,27 @@ | |||
title: End-of-chapter quiz | |||
quiz: 8 | |||
|
|||
- local: chapter9 | |||
title: 9. Building and sharing demos | |||
new: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI this field will eventually render a "New" icon on the frontend - see internal Slack thread: https://huggingface.slack.com/archives/C01SJL5C5LK/p1651736595622049
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mishig25 should I expect to see the "new" icon already in this PR or is this something that will become visible once I re-build the content on the release
branch (for prod)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good
@lewtun please let me know if there's anything I need to do for the new gradio chapters |
* blocks section Co-authored-by: Abubakar Abid <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done a final pass through the whole chapter and reading it again was a real pleasure - excellent job @dawoodkhan82 and @abidlabs 😍 !
I've added a bunch of nits to streamline the text and formatting with the other course chapters, but it's mostly minor stuff that should be easy to include :)
One last thing: @osanseviero suggested mentioning the Blocks event in chapter9/1
and chapter9/7
. How about we include a small description of the event at the end of each of these sections?
Once we merge this, I'll then generate all the Colab notebooks so people can easily play with the demos :)
LGTM, love the cute emojis sprinkled in the chapter 😄 |
Use this branch
gradio_newfront
as your base branch when you are making changes to chapter 9 until we deploy chapter 9You can test your changes locally with:
Note: make sure to change
~/Desktop/course/chapters/en
based on your filesystemThe command above should open http://localhost:3000/ automaatically. You'll see 404 on http://localhost:3000/, ignore it and just click whatever section you are editing on the left navbar.
Also, hot reloading is enabled by default, you should be able to see your changes live
TODO