Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate into Vietnamese chap [6-9] - DONE #303

Merged
merged 48 commits into from
Sep 2, 2022
Merged

Conversation

honghanhh
Copy link
Contributor

Finish from chapter 6 to 8.

6 - The 🤗 Tokenizers library

7 - Main NLP tasks

8 - How to ask for help

Please feel free to review it @lewtun.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 1, 2022

The documentation is not available anymore as the PR was closed or merged.

@honghanhh honghanhh changed the title Translate into Vietnamese chap [6-8] Translate into Vietnamese chap [6-9] - DONE Sep 1, 2022
Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work with another huge translation @honghanhh - thank you 🤗 !!

Everything looks good, but we just need to remove all the English .md files in the chapter6 folder so that we render the Vietnamese .mdx ones. Would you like to do that in this PR and then we can announce the course is fully available in Vietnamese?

@honghanhh
Copy link
Contributor Author

remove

@lewtun Sure, I have just updated them.
I hope my translation can contribute to the course and the community. Thanks.

@lewtun
Copy link
Member

lewtun commented Sep 2, 2022

remove

@lewtun Sure, I have just updated them. I hope my translation can contribute to the course and the community. Thanks.

Great, thank you! I checked the render and it looks great :)

@lewtun lewtun merged commit ececc02 into huggingface:main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants