Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zh-CN - Chapter 6finished #290

Merged
merged 51 commits into from
Aug 4, 2022
Merged

zh-CN - Chapter 6finished #290

merged 51 commits into from
Aug 4, 2022

Conversation

yaoqih
Copy link
Contributor

@yaoqih yaoqih commented Aug 1, 2022

we have completed the translation of chapters 6, below is the list of contributors

@petrichor1122

Fast tokenizers in the QA pipeline.md 391
Fast tokenizers' special powers.md 323
Normalization and pre-tokenization.md 85

@1375626371

Introduction.md 42
10.mdx 269
Training a new tokenizer from an old one.md 193
Building a tokenizer, block by block.md 447
Tokenizers, check!.md 13

@zhlhyx

Byte-Pair Encoding tokenization.md 285
Unigram tokenization.md 309
WordPiece tokenization.md 302

yaoqih and others added 30 commits April 12, 2022 00:53
 Add zh to the languages field in the build_documentation.yml and build_pr_documentation.yml files
Remove all these sections that haven't been translated yet
Remove Chapter 0 from the table of contents since it hasn't been translated yet
Fixed an error in the translation format of Chapter 1, Section 3
·Fixed some formatting errors
·Moved Chapters 0 and 2 to Simplified Chinese
Formatting revisions and some translation corrections
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 1, 2022

The documentation is not available anymore as the PR was closed or merged.

@yaoqih
Copy link
Contributor Author

yaoqih commented Aug 1, 2022

Before I submit the changes, I will synchronize the data of huggingface:main branch, and then when I submit it, I find that there are changes in addition to the chapter I submitted, I am very confused. I'm currently ignoring changes other than the chapter I commit and then committing. I found that the changes are in the code formatting section. I also tried running git checkout main -- chapters/fr but found no changes.
I can't solve this problem at the moment, I need to trouble you to help me solve it.
Thank you!

@lvwerra
Copy link
Member

lvwerra commented Aug 4, 2022

The style check should be fixed now. You can do it usually with

make style && make quality

You reverted the merge of main into your branch which deleted a bunch of files in this commit:6403eaa

We need to revert that commit before merging your contribution. I can do it for you if you like, just let me know.

@yaoqih
Copy link
Contributor Author

yaoqih commented Aug 4, 2022

The style check should be fixed now. You can do it usually with

make style && make quality

You reverted the merge of main into your branch which deleted a bunch of files in this commit:6403eaa

We need to revert that commit before merging your contribution. I can do it for you if you like, just let me know.

Of course, since I am not very proficient in the operation of github branches, there may be some oversights. Thanks a lot if you can help fix it.

Copy link
Member

@lvwerra lvwerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Looks good now!

@lvwerra lvwerra merged commit b4b2316 into huggingface:main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants