Merge pull request #26 from huggingface/fix-qa-offsets

Fix inequalities in answer spans for QA chapter
huggingface · Mar 21, 2022 · 1a8221f · 1a8221f
1 parent 82c57b1
commit 1a8221f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/chapters/en/chapter7/section7.mdx b/chapters/en/chapter7/section7.mdx
@@ -291,7 +291,7 @@ for i, offset in enumerate(inputs["offset_mapping"]):
     context_end = idx - 1
 
     # If the answer is not fully inside the context, label is (0, 0)
-    if offset[context_start][0] > end_char or offset[context_end][1] < start_char:
+    if offset[context_start][0] > start_char or offset[context_end][1] < end_char:
         start_positions.append(0)
         end_positions.append(0)
     else:
@@ -398,7 +398,7 @@ def preprocess_training_examples(examples):
         context_end = idx - 1
 
         # If the answer is not fully inside the context, label is (0, 0)
-        if offset[context_start][0] > end_char or offset[context_end][1] < start_char:
+        if offset[context_start][0] > start_char or offset[context_end][1] < end_char:
             start_positions.append(0)
             end_positions.append(0)
         else: