-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(refactor): ✨ remove brew command and add proper ollama installation for colab to run in free tier #223
feat(refactor): ✨ remove brew command and add proper ollama installation for colab to run in free tier #223
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@@ -72,13 +72,74 @@ | |||
" llama-index-llms-ollama" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -72,13 +72,74 @@ | |||
" llama-index-llms-ollama" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -72,13 +72,74 @@ | |||
" llama-index-llms-ollama" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -72,13 +72,74 @@ | |||
" llama-index-llms-ollama" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few notes but LGTM overall, thanks!
…ion for colab to run in free tier Signed-off-by: Onuralp SEZER <[email protected]>
239d3d4
to
61cd216
Compare
@stevhliu thank you and all changes are done. |
the CI times out after 6 hrs, there's no issue regarding this notebook. |
Yup :) |
Hello, I was waiting for a while and Is there anything I should do or check about it ? Thank you. |
Thanks for solving the issue I created!! 😄 |
The frontend team is working on a fix. I'll merge this for you @onuralpszr once its ready 👍 |
@stevhliu I did merge but still looks stuck on CI I was checking what causing it. I also notice other comment on other PR so I wanted to let you know. |
How odd! Can you try getting the latest changes from |
@stevhliu I did already If you check my merge commit, I will do it again but that's for new cookbook so won't make big difference anyway |
Ok, with the latest fix in #239 the CI should pass now. Can you update and get the latest fix again? Thanks again for your patience! 🤗 |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@stevhliu well it is merged but I cannot see URL ? :) at least I wish to see dev-docs :) |
You can see them here |
What does this PR do?
This PR refactors the setup for Ollama in Colab by removing the Homebrew command and adding a compatible installation method for the google colab free tier without requirement of "terminal/console"
Fixes #123
Who can review?
@merveenoyan and @stevhliu.