Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/custom instruction #903

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

KartikGS
Copy link
Contributor

@KartikGS KartikGS commented Mar 5, 2024

fixes #748

Adding anchor to input custom instruction in Settings layout and adding new route for custom instruction input in src/routes/settings/custom.
image

Adding custom instruction to the setting store in src/lib/stores/settings.ts, src/lib/types/Settings.ts 1, src/lib/types/Settings.ts 2, src/routes/+layout.server.ts and src/routes/settings/+server.ts.

Appending custom instruction to preprompt in src/routes/+page.svelte 1 and src/routes/+page.svelte 2.
image

@KartikGS KartikGS force-pushed the feat/custom_instruction branch from 04a893f to 3d5ef4a Compare March 6, 2024 12:16
@nsarrazin
Copy link
Collaborator

Hi! Appreciate the work on this, I think it could be a useful feature, and seems pretty well implemented 😄

A few open questions for me:

  • could we put the text area in /settings instead of having a separate route just for custom instructions? Not 100% sure about this
  • Should custom instructions also run with assistants ? Or should they only run when using a model without an assistant.

Not sure, wdyt @gary149 @mishig25 ?

@nsarrazin nsarrazin added enhancement New feature or request front This issue is related to the front-end of the app. back This issue is related to the Svelte backend or the DB labels Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back This issue is related to the Svelte backend or the DB enhancement New feature or request front This issue is related to the front-end of the app.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Proposal] Custom Instructions
2 participants