🗃️ Create index on users.username #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-c
approved these changes
Feb 13, 2024
| @@ -26,7 +26,7 @@ export const load = async ({ url, locals }) => { | |||
|
|
|||
| // fetch the top assistants sorted by user count from biggest to smallest, filter out all assistants with only 1 users. filter by model too if modelId is provided | |||
| const filter: Filter<Assistant> = { | |||
| modelId: modelId ?? { $exists: true }, | |||
| ...(modelId && { modelId }), | |||
There was a problem hiding this comment.
will keep in mind (here both lines below already use this syntax 👼)
nsarrazin
approved these changes
Feb 14, 2024
ice91
pushed a commit
to ice91/chat-ui
that referenced
this pull request
Oct 30, 2024
* 🗃️ Create index on `users.username`
* 🗃️ Do not do db.assistants.find({modelId: {$exists: true}) since it's always true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With 300k users (:exploding_head:) this was a slow query.
Happened on pages like these: https://huggingface.co/chat/assistants?user=julien-c
We may want to link to https://huggingface.co/chat/assistants?userId=xxxx instead, as in some edge cases two users can have the same
username. But leaving it up to you for another PRNote: index is already in prod