-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple Email Authorization #801
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good at the code level! Left some minor comments and will test it a bit later to make sure the functionality is working 😁
Adding email validation Co-authored-by: Nathan Sarrazin <[email protected]>
More detailed error when missing email Co-authored-by: Nathan Sarrazin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks for the contrib, and sorry for the delay in merging this!
* Add ALLOWED_USER_EMAILS validation in login callback * Update src/routes/login/callback/+page.server.ts Adding email validation Co-authored-by: Nathan Sarrazin <[email protected]> * Update src/routes/login/callback/+page.server.ts More detailed error when missing email Co-authored-by: Nathan Sarrazin <[email protected]> --------- Co-authored-by: Nathan Sarrazin <[email protected]>
This PR adds simple email authorization using a new variable
ALLOWED_USER_EMAILS
inenv.local
.This variable should not have any effect if it's undefined or an empty array.
See #795 for more details.