Assistants feature #639

nsarrazin · 2023-12-15T11:34:59Z

Current look

New assistant

Assistant (created by you)

Assistant (created by another user)

Conversation starting page

Ongoing conversation

(note top of page indicator and avatar in side menu)

Receiving a shared assistant

Assistant without an avatar

hungryalgo · 2023-12-19T16:43:30Z

This feature reminds me of the Agents feature that you were doing, but this seems very different without tools usage.

Why is the Agents feature dropped? Or why is this one having more precedence?
Both seem very interesting, I am guessing that this Assistants feature is more important, but not sure why.

#462

thanks!

nsarrazin · 2023-12-21T13:37:32Z

This is ready for review @gary149, it's only missing the edit an existing assistant feature but I don't think it's a blocker and the rest is done

mishig25 · 2023-12-22T15:10:10Z

On the create new assistant modal, there is this cutoff text Cli...

mishig25 · 2023-12-22T15:11:27Z

Maybe in the start messages, as soon as message gets empty, delete that empty item from the list?

mishig25 · 2023-12-22T15:13:23Z

For the system prompts, maybe we can create and link to an example dataset of 10 system prompts for the inspiration. Something like https://huggingface.co/datasets/fka/awesome-chatgpt-prompts

mishig25 · 2023-12-22T15:17:54Z

Once assistant is created, you can't edit the system prompt. Is it expected?

src/routes/assistant/[assistantId]/+page.svelte

src/routes/assistant/[assistantId]/+page.server.ts

src/routes/conversation/+server.ts

nsarrazin · 2024-01-15T09:43:57Z

Merged back #662 into this branch. There's a feature flag if we think it's not a feature we want in prod yet 😄

gururise · 2024-01-17T00:25:54Z

Testing this PR and I can't seem to create a "new assistant" as the option appears to be missing:

I did add the following to .env.local:
ENABLE_ASSISTANTS=true

nsarrazin · 2024-01-17T09:33:33Z

@gururise thanks for testing! By any chance do you have any openid config ? We've configured it so that only logged-in users can create assistants if openid is configured. But it should be accessible if you have no login setup. I'll have a look as well.

gururise · 2024-01-17T14:45:01Z

@gururise thanks for testing! By any chance do you have any openid config ? We've configured it so that only logged-in users can create assistants if openid is configured. But it should be accessible if you have no login setup. I'll have a look as well.

I only tested without openid. I'll try with openid.

gururise · 2024-01-17T16:20:18Z

Just tried with OpenID and it works. One issue is that the "created by user" is always null when using OpenID from google. If we don't have the user's name, could we just use their email address instead?

Are the assistants shared across all logins?

nsarrazin · 2024-01-17T16:23:39Z

Ok then I need to fix it so that it also works without OpenID! 😁 And good catch on the created by, will see if we can default to something else.

Assistants are public but not shared by default, (you can share them using the URL in the settings)

nsarrazin · 2024-01-18T15:10:31Z

Should be better @gururise 😄

gururise · 2024-01-18T16:08:21Z

Should be better @gururise 😄

Works perfectly now! Thanks!

* Add rate-limited image generating endpoint * Add generate avatar button * add little padding for firefox focus ring * format * fix upload image bug * Fix uploads, replace reset by delete * left-align buttons * rm avatar generation feature * final changes to delete feature * sys prompt min height * padding * Add object-cover everywhere --------- Co-authored-by: Victor Mustar <[email protected]>

SvCy · 2024-02-02T19:02:10Z

Really glad to see that it's finally up! 🤗

* First push on assistants * push fixes * fix add assistant * Sign up works * lint * mobile layout fixes * design fixes * Merge branch 'main' into feature/assistants * fix copy button * add error feedback * hide duplicate feature * remove wrong comments * add autoredirect if assistant is missing * latest changes: - add edit feature - hash assistant avatar - get rid of ugly line - check for non existent avatar - make a better looking upload icon * Update src/routes/conversation/+server.ts Co-authored-by: Mishig <[email protected]> * reused type more cleanly * fix type in shared conversation * fixed feature * fix: share conv with an assistant * delete assistant avatars in db when deleting avatar * affordance on avatar upload * improve assistant conv start on mobile * settings modal fly in * better mobile intro * mobile padding * link affordance * Make assistants disabled by default, but enabled in huggingchat * lint * Fix bottom model name * ui tweaks * Initial work on chat thumbnails * fix build * Get rid of deps * Update src/routes/settings/assistants/[assistantId]/avatar/+server.ts Co-authored-by: Mishig <[email protected]> * add comment to app_base * Use event modifiers * Use CSS uppercase instead everywhere * Update src/lib/components/NavMenu.svelte Co-authored-by: Mishig <[email protected]> * Update src/routes/+layout.server.ts Co-authored-by: Mishig <[email protected]> * Clearer error message for avatar size check * one less op on flag check * revert back preventDefault change in LoginModal * Update src/routes/settings/+layout.svelte Co-authored-by: Mishig <[email protected]> * Update src/routes/+layout.server.ts Co-authored-by: Mishig <[email protected]> * Update src/routes/+layout.server.ts Co-authored-by: Mishig <[email protected]> * Added app logo in corner of thumbnail and clamped description length * improved thumbnails * Remove warnings * Reuse Assisntants settings component (huggingface#678) * Update Assisntants settings * format * [Assistants] Use textToImage task for avatar generation (huggingface#662) * Generate assistants avatar using stablediffusion * wording * Update +page.server.ts Co-authored-by: Michael Fried <[email protected]> * Add timeout & controls to avatar generation * Add controls for avatar generation in .env * Update src/routes/+layout.server.ts Co-authored-by: Mishig <[email protected]> * Update src/lib/components/AssistantSettings.svelte Co-authored-by: Mishig <[email protected]> * Fix avatar gen feature flag * Can only upload avatar if generate is unchecked --------- Co-authored-by: Michael Fried <[email protected]> Co-authored-by: Mishig <[email protected]> * layout * small fixes * hint * Show feature if login is not required * lint * Only show creator name if it's defined * tweaks * thumbnail update * thumbnail font-size * Always display model at the bottom * Bottom links now go to settings * fix lint * silent release * fix bg on share link * [Assistant] Delete avatar button instead of reset (huggingface#725) * Add rate-limited image generating endpoint * Add generate avatar button * add little padding for firefox focus ring * format * fix upload image bug * Fix uploads, replace reset by delete * left-align buttons * rm avatar generation feature * final changes to delete feature * sys prompt min height * padding * Add object-cover everywhere --------- Co-authored-by: Victor Mustar <[email protected]> --------- Co-authored-by: Mishig <[email protected]> Co-authored-by: Victor Mustar <[email protected]> Co-authored-by: Michael Fried <[email protected]>

First push on assistants

e85d1e1

nsarrazin added enhancement New feature or request front This issue is related to the front-end of the app. back This issue is related to the Svelte backend or the DB labels Dec 15, 2023

mishig25 mentioned this pull request Dec 20, 2023

Generalize RAG + PDF Chat feature #641

Draft

nsarrazin added 8 commits December 20, 2023 13:02

push fixes

3ba2eea

fix add assistant

40a6a96

Sign up works

20cfabf

lint

835874b

mobile layout fixes

0240db1

design fixes

78be831

Merge branch 'main' into feature/assistants

2a8821c

fix copy button

7dc10ab

nsarrazin marked this pull request as ready for review December 20, 2023 13:49

Merge branch 'main' into feature/assistants

0eea54c

nsarrazin requested a review from gary149 December 20, 2023 14:11

nsarrazin added 2 commits December 21, 2023 10:03

add error feedback

3ad46cb

hide duplicate feature

5b3ee70

nsarrazin added 2 commits December 21, 2023 14:59

remove wrong comments

128c5a3

add autoredirect if assistant is missing

1be810e

gary149 requested a review from mishig25 December 22, 2023 14:10

mishig25 reviewed Dec 22, 2023

View reviewed changes

src/routes/assistant/[assistantId]/+page.svelte Outdated Show resolved Hide resolved

mishig25 reviewed Dec 22, 2023

View reviewed changes

src/routes/assistant/[assistantId]/+page.server.ts Outdated Show resolved Hide resolved

mishig25 reviewed Dec 22, 2023

View reviewed changes

src/routes/conversation/+server.ts Outdated Show resolved Hide resolved

gary149 and others added 7 commits January 18, 2024 13:18

layout

69c223d

small fixes

1900083

hint

744d4a0

Show feature if login is not required

003cd30

Merge branch 'main' into feature/assistants

7652355

lint

c89c620

Only show creator name if it's defined

285050f

gary149 and others added 9 commits January 18, 2024 23:12

tweaks

5165490

thumbnail update

b672fb7

thumbnail font-size

732e338

Always display model at the bottom

52834ce

Bottom links now go to settings

11fe137

fix lint

6da1347

silent release

4a12786

Merge branch 'main' into feature/assistants

0ede716

fix bg on share link

cf00c70

nsarrazin mentioned this pull request Jan 24, 2024

[Assistant] Delete avatar button instead of reset #725

Merged

nsarrazin merged commit 992a8de into main Jan 24, 2024
3 checks passed

nsarrazin deleted the feature/assistants branch January 24, 2024 16:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Assistants feature #639

Assistants feature #639

nsarrazin commented Dec 15, 2023 •

edited

Loading

hungryalgo commented Dec 19, 2023

nsarrazin commented Dec 21, 2023

mishig25 commented Dec 22, 2023

mishig25 commented Dec 22, 2023 •

edited

Loading

mishig25 commented Dec 22, 2023

mishig25 commented Dec 22, 2023

nsarrazin commented Jan 15, 2024

gururise commented Jan 17, 2024

nsarrazin commented Jan 17, 2024

gururise commented Jan 17, 2024

gururise commented Jan 17, 2024 •

edited

Loading

nsarrazin commented Jan 17, 2024

nsarrazin commented Jan 18, 2024

gururise commented Jan 18, 2024

SvCy commented Feb 2, 2024

Assistants feature #639

Assistants feature #639

Conversation

nsarrazin commented Dec 15, 2023 • edited Loading

Current look

New assistant

Assistant (created by you)

Assistant (created by another user)

Conversation starting page

Ongoing conversation

Receiving a shared assistant

Assistant without an avatar

hungryalgo commented Dec 19, 2023

nsarrazin commented Dec 21, 2023

mishig25 commented Dec 22, 2023

mishig25 commented Dec 22, 2023 • edited Loading

mishig25 commented Dec 22, 2023

mishig25 commented Dec 22, 2023

nsarrazin commented Jan 15, 2024

gururise commented Jan 17, 2024

nsarrazin commented Jan 17, 2024

gururise commented Jan 17, 2024

gururise commented Jan 17, 2024 • edited Loading

nsarrazin commented Jan 17, 2024

nsarrazin commented Jan 18, 2024

gururise commented Jan 18, 2024

SvCy commented Feb 2, 2024

nsarrazin commented Dec 15, 2023 •

edited

Loading

mishig25 commented Dec 22, 2023 •

edited

Loading

gururise commented Jan 17, 2024 •

edited

Loading